Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: writing byte one at a time #320

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: writing byte one at a time #320

merged 1 commit into from
Jan 17, 2025

Conversation

panuhorsmalahti
Copy link
Contributor

  • Parsing was failing if bytes were written one by one since we convert partial UTF-8 characters (for example) into string

@panuhorsmalahti panuhorsmalahti force-pushed the fix/writing-byte-at-time branch 4 times, most recently from 3246ce2 to 010464c Compare January 16, 2025 15:06
@panuhorsmalahti panuhorsmalahti marked this pull request as ready for review January 16, 2025 15:06
@panuhorsmalahti panuhorsmalahti requested review from a team and jakolehm January 16, 2025 15:06
@panuhorsmalahti panuhorsmalahti force-pushed the fix/writing-byte-at-time branch from 010464c to 3c01bc5 Compare January 17, 2025 09:13
@panuhorsmalahti panuhorsmalahti merged commit 67961f2 into main Jan 17, 2025
3 checks passed
@panuhorsmalahti panuhorsmalahti deleted the fix/writing-byte-at-time branch January 17, 2025 09:25
@panuhorsmalahti panuhorsmalahti mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jweak jweak jweak approved these changes

@jakolehm jakolehm Awaiting requested review from jakolehm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panuhorsmalahti @jweak